Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth dialog - enable context isolation #102926

Merged
merged 4 commits into from Jul 21, 2020
Merged

auth dialog - enable context isolation #102926

merged 4 commits into from Jul 21, 2020

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jul 20, 2020 •
edited

I think it would be safe to enable contextIsolation now that preload.ts conditionally uses contextBridge if it detects that it runs context isolated.

//cc @joaomoreno

PS: quite surprisingly we have no NLS story for this dialog, otherwise we could not enable sandbox yet.

@bpasero bpasero added this to the July 2020 milestone Jul 20, 2020
@bpasero
Copy link
Member Author

bpasero commented Jul 21, 2020

Ready for review again.

deepak1556
deepak1556 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually verified the auth flow continues to work.

@deepak1556 deepak1556 merged commit 7e40e8e into master Jul 21, 2020
@deepak1556 deepak1556 deleted the ben/auth-isolated branch July 21, 2020 06:16
joaomoreno pushed a commit that referenced this pull request Jul 21, 2020
@bpasero @joaomoreno
auth dialog - enable context isolation (#102926)
956a431 
* auth dialog - enable context isolation

* remote nativeWindowOpen
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
July 2020
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpasero @deepak1556